Remove check for (now optional) ENV-variable for GCP Authentication#4966
Merged
lassetyr merged 1 commit intoMar 15, 2023
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4966 +/- ##
=============================================
+ Coverage 63.86% 63.88% +0.01%
- Complexity 13472 13481 +9
=============================================
Files 1674 1674
Lines 66100 66107 +7
Branches 7150 7145 -5
=============================================
+ Hits 42216 42233 +17
+ Misses 21498 21491 -7
+ Partials 2386 2383 -3
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Mar 14, 2023
vpaturet
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google now supports/recommends defining pubsub-authentication through "workload identity" (https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity).
This PR removes the check for the - now optional - ENV variable
GOOGLE_APPLICATION_CREDENTIALS, and thus assumes that config is correct when starting up.