Skip to content

Remove check for (now optional) ENV-variable for GCP Authentication#4966

Merged
lassetyr merged 1 commit into
opentripplanner:dev-2.xfrom
entur:entur_extend_gcp_auth_support
Mar 15, 2023
Merged

Remove check for (now optional) ENV-variable for GCP Authentication#4966
lassetyr merged 1 commit into
opentripplanner:dev-2.xfrom
entur:entur_extend_gcp_auth_support

Conversation

@lassetyr

Copy link
Copy Markdown
Contributor

Google now supports/recommends defining pubsub-authentication through "workload identity" (https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity).

This PR removes the check for the - now optional - ENV variable GOOGLE_APPLICATION_CREDENTIALS, and thus assumes that config is correct when starting up.

@lassetyr lassetyr added +Sandbox This will be implemented as a Sandbox feature +Real-Time The issue/PR is related to RealTime updates labels Mar 14, 2023
@lassetyr lassetyr requested a review from a team as a code owner March 14, 2023 14:13
@codecov

codecov Bot commented Mar 14, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (703d25c) 63.86% compared to head (0f699c4) 63.88%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4966      +/-   ##
=============================================
+ Coverage      63.86%   63.88%   +0.01%     
- Complexity     13472    13481       +9     
=============================================
  Files           1674     1674              
  Lines          66100    66107       +7     
  Branches        7150     7145       -5     
=============================================
+ Hits           42216    42233      +17     
+ Misses         21498    21491       -7     
+ Partials        2386     2383       -3     
Impacted Files Coverage Δ
...er/ext/siri/updater/SiriETGooglePubsubUpdater.java 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t2gran t2gran added this to the 2.3 milestone Mar 14, 2023
@vpaturet vpaturet self-requested a review March 15, 2023 09:33
@lassetyr lassetyr merged commit 450f311 into opentripplanner:dev-2.x Mar 15, 2023
@lassetyr lassetyr deleted the entur_extend_gcp_auth_support branch March 15, 2023 09:35
t2gran pushed a commit that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Real-Time The issue/PR is related to RealTime updates +Sandbox This will be implemented as a Sandbox feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants