Allow OTP to start when unexpected enum values is encountered in config.

[t2gran]

Summary

Enum values can be added or deleted; Hence to allow OTP to be forward and backward compatible unknown values must be logged(WARNING) and ignored. The Server should not terminate.

The new log items look like this:

13:45:56.208 WARN (NodeAdapter.java:172) The enum value 'Fake' is not legal. Expected one of [APIBikeRental, APIServerInfo, APIGraphInspectorTile, APIUpdaterStatus, ConsiderPatternsForDirectTransfers, DebugClient, FloatingBike, MinimumTransferTimeIsDefinitive, OptimizeTransfers, ParallelRouting, TransferConstraints, ActuatorAPI, AsyncGraphQLFetchers, DataOverlay, FaresV2, FlexRouting, GoogleCloudStorage, RealtimeResolver, ReportApi, SandboxAPIGeocoder, SandboxAPILegacyGraphQLApi, SandboxAPIMapboxVectorTilesApi, SandboxAPIParkAndRideApi, SandboxAPITransmodelApi, SandboxAPITravelTime, TransferAnalyzer, VehicleToStopHeuristics]. Parameter: otpFeatures. Source: otp-config.json.
13:45:56.208 WARN (NodeAdapter.java:169) Unexpected config parameter: 'otpFeatures.Fake:true' in 'otp-config.json'

In this case I started OTP with a "Fake" feature.

Issue

Partially fixes #4980

Unit tests

Updated

Documentation

Updated

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (11d0094) 63.90% compared to head (f38676a) 63.92%.

❗ Current head f38676a differs from pull request most recent head fb1cebb. Consider uploading reports for the commit fb1cebb to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #4983      +/-   ##
=============================================
+ Coverage      63.90%   63.92%   +0.01%     
- Complexity     13501    13513      +12     
=============================================
  Files           1674     1674              
  Lines          66152    66196      +44     
  Branches        7155     7158       +3     
=============================================
+ Hits           42274    42314      +40     
- Misses         21492    21497       +5     
+ Partials        2386     2385       -1     

Impacted Files	Coverage Δ
...opentripplanner/standalone/config/BuildConfig.java	98.46% <100.00%> (ø)
...g/opentripplanner/standalone/config/OtpConfig.java	94.11% <100.00%> (+1.26%)	⬆️
...pentripplanner/standalone/config/RouterConfig.java	87.03% <100.00%> (ø)
.../standalone/config/framework/json/NodeAdapter.java	94.56% <100.00%> (+0.51%)	⬆️
...dalone/config/framework/json/ParameterBuilder.java	90.45% <100.00%> (-0.85%)	⬇️
...lone/config/routerconfig/TransitRoutingConfig.java	96.19% <100.00%> (ø)

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[leonardehrenfried]

I have a couple of requests.