Add filename to graph report - #4984
Merged
leonardehrenfried merged 7 commits intoMar 30, 2023
Merged
Conversation
leonardehrenfried
requested changes
Mar 24, 2023
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
I don't think we want to add mutable state to the issue store. @t2gran and @vpaturet can advise how to implement this without it.
There are two possibilities that I can think of:
- pass the file name down the call stack
- make a custom implementation of the issue store that has a fixed file name, instantiate it per file and merge the results with the main one afterwards
This would be a good topic for Gitter, the dev meeting or a GH issue.
Member
|
Please resolve the conflicts. |
t2gran
requested changes
Mar 29, 2023
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
After looking at this, I think the approach is ok. But, I have a few suggestions for improvment.
…e the source, rename filename to currentSource, rename methods to indicate the intention, add javadoc to the renamed methods
t2gran
reviewed
Mar 29, 2023
t2gran
reviewed
Mar 29, 2023
t2gran
reviewed
Mar 29, 2023
t2gran
requested changes
Mar 29, 2023
… that it delegates the type and message to the wrapped issue
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4984 +/- ##
=============================================
+ Coverage 64.08% 64.13% +0.05%
- Complexity 13592 13617 +25
=============================================
Files 1675 1676 +1
Lines 66255 66418 +163
Branches 7149 7164 +15
=============================================
+ Hits 42459 42598 +139
- Misses 21422 21435 +13
- Partials 2374 2385 +11
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bas-hbt
requested review from
leonardehrenfried and
t2gran
and removed request for
leonardehrenfried and
t2gran
March 30, 2023 12:10
t2gran
approved these changes
Mar 30, 2023
leonardehrenfried
approved these changes
Mar 30, 2023
t2gran
pushed a commit
that referenced
this pull request
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adds the file path to the dataImportIssue-message-output of the graph report to localize errors more easily