Add allowOverloading parameter to GBFS updaters and fix use of it in routing

[optionsome]

Summary

This adds optional allowOverloading parameter to the GBFS updaters and fixes use of it in routing.

Issue

This is related to MobilityData/gbfs#376 but unfortunately currently, I don't feel like there is a straightforward way to define this information in the data.

Unit tests

Updated tests.

Documentation

Updated

Changelog

From title

[codecov]

Codecov Report

Patch coverage: 89.47% and project coverage change: +0.02 🎉

Comparison is base (1206bb8) 64.25% compared to head (9835df4) 64.28%.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5024      +/-   ##
=============================================
+ Coverage      64.25%   64.28%   +0.02%     
- Complexity     13786    13791       +5     
=============================================
  Files           1689     1689              
  Lines          66773    66778       +5     
  Branches        7191     7191              
=============================================
+ Hits           42906    42925      +19     
+ Misses         21461    21450      -11     
+ Partials        2406     2403       -3     

Impacted Files	Coverage Δ
...kerental/SmooveBikeRentalDataSourceParameters.java	33.33% <ø> (-16.67%)	⬇️
...irectory/VehicleRentalServiceDirectoryFetcher.java	0.00% <ø> (ø)
...kerental/VilkkuBikeRentalDataSourceParameters.java	50.00% <ø> (ø)
...ervice/vehiclerental/model/VehicleRentalPlace.java	66.66% <ø> (ø)
...vice/vehiclerental/model/VehicleRentalVehicle.java	37.50% <ø> (ø)
.../params/GbfsVehicleRentalDataSourceParameters.java	50.00% <ø> (ø)
...g/updaters/sources/VehicleRentalSourceFactory.java	78.00% <60.00%> (+10.65%)	⬆️
...tafetchers/LegacyGraphQLBikeRentalStationImpl.java	70.00% <100.00%> (ø)
...etchers/LegacyGraphQLVehicleRentalStationImpl.java	85.71% <100.00%> (ø)
...t/smoovebikerental/SmooveBikeRentalDataSource.java	100.00% <100.00%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[leonardehrenfried]

Could you please write a test? Some good examples of how to do it:

• https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/src/test/java/org/opentripplanner/street/model/edge/VehicleParkingPreferredTagsTest.java
• https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/src/test/java/org/opentripplanner/street/model/edge/StreetEdgeRentalTraversalTest.java
• https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/src/test/java/org/opentripplanner/street/model/edge/VehicleParkingEdgeTest.java

[leonardehrenfried]

???

Can you not just call allowOverloading()?

[optionsome]

I think I've implemented everything we discussed in the dev meeting. Only thing I'm still unsure about is what to do with the allowOverloading in the GraphQL schema. I don't know if anyone is actually using it so we could maybe just rename it to be overloadingAllowed?

[leonardehrenfried]

Suggested change

	class VehicleRentalEdgeTest extends GraphRoutingTest {
	class VehicleRentalEdgeTest {

Do you need the GraphRoutingTest?

[optionsome]

Well spotted. Seems like it's not needed. I used another test class as the basis for mine but it was unnecessary in the other class as well so I removed it from both.

[leonardehrenfried]

Please resolve the conflicts.