Skip to content

Remove dead build configuration parameter (extraEdgesStopPlatformLink) - #5080

Merged
leonardehrenfried merged 3 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:remove-dead-linkparam
May 2, 2023
Merged

Remove dead build configuration parameter (extraEdgesStopPlatformLink)#5080
leonardehrenfried merged 3 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:remove-dead-linkparam

Conversation

@vesameskanen

Copy link
Copy Markdown
Contributor

Summary

Parameter called extraEdgesStopPlatformLink has not been functional for a long time. Remove it from confusing OTP2 users and developers.

@vesameskanen
vesameskanen requested a review from a team as a code owner April 28, 2023 08:31
@vesameskanen vesameskanen added the +Config Change This PR might require the configuration to be updated. label Apr 28, 2023
@codecov

codecov Bot commented Apr 28, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (08fe1f4) 64.59% compared to head (eca0b5c) 64.53%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5080      +/-   ##
=============================================
- Coverage      64.59%   64.53%   -0.07%     
+ Complexity     13890    13886       -4     
=============================================
  Files           1711     1715       +4     
  Lines          67074    67110      +36     
  Branches        7206     7207       +1     
=============================================
- Hits           43327    43307      -20     
- Misses         21327    21382      +55     
- Partials        2420     2421       +1     
Impacted Files Coverage Δ
...opentripplanner/standalone/config/BuildConfig.java 98.43% <ø> (-0.03%) ⬇️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonardehrenfried leonardehrenfried changed the title Remove dead build configuration parameter Remove dead build configuration parameter (extraEdgesStopPlatformLink) Apr 28, 2023
@leonardehrenfried
leonardehrenfried requested a review from t2gran May 2, 2023 08:12
@leonardehrenfried
leonardehrenfried merged commit 4d057f1 into opentripplanner:dev-2.x May 2, 2023
@t2gran t2gran added this to the 2.4 milestone May 2, 2023
@t2gran t2gran added the !Technical Debt Improve code quality, no functional changes. label May 2, 2023
t2gran pushed a commit that referenced this pull request May 2, 2023
@vesameskanen
vesameskanen deleted the remove-dead-linkparam branch May 23, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Config Change This PR might require the configuration to be updated. !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants