OSM: Break out of processing a malformed level map - #5096
Merged
t2gran merged 4 commits intoMay 15, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5096 +/- ##
=============================================
+ Coverage 64.51% 64.58% +0.07%
- Complexity 14031 14061 +30
=============================================
Files 1725 1728 +3
Lines 67222 67319 +97
Branches 7200 7206 +6
=============================================
+ Hits 43365 43481 +116
+ Misses 21434 21423 -11
+ Partials 2423 2415 -8
☔ View full report in Codecov by Sentry. |
Member
|
You need to run |
leonardehrenfried
approved these changes
May 10, 2023
leonardehrenfried
added
the
!Bug
leonardehrenfried
enabled auto-merge
May 12, 2023 13:03
t2gran
disabled auto-merge
May 15, 2023 14:17
t2gran
approved these changes
May 15, 2023
t2gran
pushed a commit
that referenced
this pull request
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the OSM parser from crashing when encountering a level_map that doesn't actually include levels.
Issue
Closes #5094
Unit tests
No added tests.
Manual test was successful, new if branch triggered only on the one curre
Documentation
No documentation added, trivial change in essence amounting to a null-check before a method that crashes when supplied a null value.