Repository navigation
Merge norway traversal calculator into default - #5106
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5106 +/- ##
=============================================
+ Coverage 64.62% 64.76% +0.14%
- Complexity 14067 14098 +31
=============================================
Files 1728 1729 +1
Lines 67314 67356 +42
Branches 7205 7205
=============================================
+ Hits 43502 43624 +122
+ Misses 21396 21311 -85
- Partials 2416 2421 +5
☔ View full report in Codecov by Sentry. |
optionsome
marked this pull request as ready for review
May 10, 2023 10:24
leonardehrenfried
approved these changes
May 10, 2023
vesameskanen
self-requested a review
May 11, 2023 06:36
vesameskanen
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the default intersection cost calculator to have 0 second penalty for driving through an intersection with no traffic lights which was included in the norway intersection cost calculator before and removes the norway intersection cost calculator as it has no use anymore. We discussed this in a dev meeting earlier and everyone thought that the travel time estimates were more realistic with the norway calculator.
Issue
closes #5105
Unit tests
Updated tests but one is still failing.
Documentation
Documentation is updated.
Changelog
From title