Skip to content

Merge norway traversal calculator into default - #5106

Merged
optionsome merged 2 commits into
dev-2.xfrom
update-default-intersection-model
May 11, 2023
Merged

optionsome merged 2 commits into
dev-2.xfrom
update-default-intersection-model

Conversation

@optionsome

Copy link
Copy Markdown
Member

Summary

Updates the default intersection cost calculator to have 0 second penalty for driving through an intersection with no traffic lights which was included in the norway intersection cost calculator before and removes the norway intersection cost calculator as it has no use anymore. We discussed this in a dev meeting earlier and everyone thought that the travel time estimates were more realistic with the norway calculator.

Issue

closes #5105

Unit tests

Updated tests but one is still failing.

Documentation

Documentation is updated.

Changelog

From title

@optionsome optionsome added !Improvement A functional improvement or micro feature +Config Change This PR might require the configuration to be updated. labels May 10, 2023
@optionsome optionsome added this to the 2.4 (next release) milestone May 10, 2023
@codecov

codecov Bot commented May 10, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (31ab3d4) 64.62% compared to head (a952590) 64.76%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5106      +/-   ##
=============================================
+ Coverage      64.62%   64.76%   +0.14%     
- Complexity     14067    14098      +31     
=============================================
  Files           1728     1729       +1     
  Lines          67314    67356      +42     
  Branches        7205     7205              
=============================================
+ Hits           43502    43624     +122     
+ Misses         21396    21311      -85     
- Partials        2416     2421       +5     
Impacted Files Coverage Δ
...section_model/IntersectionTraversalCalculator.java 50.00% <ø> (+10.00%) ⬆️
...intersection_model/IntersectionTraversalModel.java 100.00% <ø> (ø)
...n_model/SimpleIntersectionTraversalCalculator.java 93.22% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@optionsome
optionsome marked this pull request as ready for review May 10, 2023 10:24
@optionsome
optionsome requested a review from a team as a code owner May 10, 2023 10:24
@vesameskanen
vesameskanen self-requested a review May 11, 2023 06:36
@optionsome
optionsome merged commit 8aca562 into dev-2.x May 11, 2023
@optionsome
optionsome deleted the update-default-intersection-model branch May 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Config Change This PR might require the configuration to be updated. !Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge norway intersection cost calculator into default (SIMPLE)

3 participants