Validate to/from in routing request

[vpaturet]

Summary

As detailed in #5163, The Transmodel API does not properly report invalid routing requests that do not define the origin or the destination of the search.
This PR adds validation for missing origin or destination in routing requests.
The Transmodel API returns then a specific error message:

{
  "data": {
    "trip": {
      "nextPageCursor": null,
      "previousPageCursor": null,
      "tripPatterns": [],
      "routingErrors": [
        {
          "code": "locationNotFound",
          "inputField": "to",
          "description": "Destination is unknown.  Can you be a bit more descriptive?"
        }
      ]
    }
  }
}

The REST API returns also a specific error message:

	{
    "requestParameters": {
        "date": "04-25-2023",
        "mode": "FLEX_ACCESS,FLEX_EGRESS,TRANSIT",
        "fromPlace": "61.11741770786395,10.451345443725588",
        "time": "2:28pm"
    },
    "error": {
        "id": 450,
        "msg": "Destination is unknown.  Can you be a bit more descriptive?",
        "message": "GEOCODE_TO_NOT_FOUND"
    }

Issue

closes #5163

Unit tests

Added unit tests.

Documentation

No

[vpaturet]

@optionsome what would be a test request to check how the GTFS API/Legacy GraphQL API handles the case where to or from are missing?

[codecov]

Codecov Report

Patch coverage: 25.92% and project coverage change: +0.14 🎉

Comparison is base (ae1aa0b) 65.15% compared to head (eddaf48) 65.29%.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5164      +/-   ##
=============================================
+ Coverage      65.15%   65.29%   +0.14%     
- Complexity     14334    14386      +52     
=============================================
  Files           1750     1750              
  Lines          67759    67833      +74     
  Branches        7205     7217      +12     
=============================================
+ Hits           44145    44294     +149     
+ Misses         21173    21090      -83     
- Partials        2441     2449       +8     

Impacted Files	Coverage Δ
...er/ext/transmodelapi/TransmodelGraphQLPlanner.java	0.00% <0.00%> (ø)
.../opentripplanner/api/resource/PlannerResource.java	5.55% <0.00%> (-1.59%)	⬇️
...nner/routing/error/RoutingValidationException.java	22.22% <0.00%> (+22.22%)	⬆️
...ntripplanner/routing/api/request/RouteRequest.java	76.34% <75.00%> (-0.13%)	⬇️
...planner/routing/service/DefaultRoutingService.java	70.00% <100.00%> (+3.33%)	⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hannesj]

This seems to break the travel time API, in which only either to or from is specified

[t2gran]

This seems to break the travel time API, in which only either to or from is specified

The travel time API does not use the DefaultRoutingService where the validation happens. The Travel time API seems to be broken in dev-2.x - but that is not related to this PR.

This call give this response:

org.opentripplanner.routing.error.RoutingValidationException: RoutingError{code: LOCATION_NOT_FOUND, inputField: FROM_PLACE} RoutingError{code: LOCATION_NOT_FOUND, inputField: FROM_PLACE}

Stacktrace

``` 0:28:42.225 ERROR [grizzly-1] (OTPExceptionMapper.java:58) Unhandled exception org.opentripplanner.routing.error.RoutingValidationException: RoutingError{code: LOCATION_NOT_FOUND, inputField: FROM_PLACE} at org.opentripplanner.street.search.TemporaryVerticesContainer.checkIfVerticesFound(TemporaryVerticesContainer.java:113) at org.opentripplanner.street.search.TemporaryVerticesContainer.(TemporaryVerticesContainer.java:54) at org.opentripplanner.ext.traveltime.TravelTimeResource.getSampleGrid(TravelTimeResource.java:170) at org.opentripplanner.ext.traveltime.TravelTimeResource.getIsochrones(TravelTimeResource.java:142) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52) at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:134) at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:177) at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:176) at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:81) at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:478) at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:400) at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:81) at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:261) at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) at org.glassfish.jersey.internal.Errors.process(Errors.java:292) at org.glassfish.jersey.internal.Errors.process(Errors.java:274) at org.glassfish.jersey.internal.Errors.process(Errors.java:244) at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:265) at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:240) at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697) at org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:367) at org.glassfish.grizzly.http.server.HttpHandler$1.run(HttpHandler.java:190) at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:535) at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:515) at java.base/java.lang.Thread.run(Thread.java:833) ```

[leonardehrenfried]

One small request.