Improve error handling in TransmodelGraph - #5192
Merged
Merged
Conversation
t2gran
added
!Improvement
t2gran
marked this pull request as draft
June 15, 2023 10:03
t2gran
changed the title
Member
Author
|
Remove Error codes from Legacy Schema |
…o "system-level"
so we can return 500, and not 200 OK.
This removes OtpExecutionResult as an intermediate step
t2gran
force-pushed
the
otp2_remove_system_error
branch
from
July 18, 2023 12:39
db07f74 to
dfb5388
Compare
t2gran
marked this pull request as ready for review
July 18, 2023 12:39
Member
|
The node download is timing out again. I'm hopefully fixing it with this commit: 465aca1 |
leonardehrenfried
self-requested a review
July 19, 2023 07:49
| case WALKING_BETTER_THAN_TRANSIT: | ||
| api = new PlannerError(Message.TOO_CLOSE); | ||
| break; | ||
| case SYSTEM_ERROR: |
Member
There was a problem hiding this comment.
What happens instead?
Member
Author
There was a problem hiding this comment.
The SYSTEM_ERROR is not returned, it is handled by the GraphQL framework and reported in the errors section of the root response - if we does not know what happen, then we should not return a partial result either - it might be corrupt.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5192 +/- ##
=============================================
+ Coverage 65.69% 65.80% +0.11%
- Complexity 14723 14741 +18
=============================================
Files 1770 1767 -3
Lines 68556 68525 -31
Branches 7288 7282 -6
=============================================
+ Hits 45037 45094 +57
+ Misses 21025 20942 -83
+ Partials 2494 2489 -5
☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Jul 21, 2023
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
The non-Transmodel part is fine.
vpaturet
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleanup the error handling in TransmodelGraph. Uncaught exceptions, witch before propagated to the Jersey Exception filter are now caught in the
TransmodelGraph#executeGraphQLmethod. I also removed one "layer" in the result chain. TheTransmodelGraphnow return a jakarta Response, not anOtpExecutionResult. This is not 100% pure, but we are not likely to support another protocol than HTTP in the near future, it is also easy to revert.This is based on #5189
Issue
No issue.
Unit tests
New test on result mapper added.
Documentation
JavaDoc only
Changelog
No
Bumping the serialization version id
No