Empty stop_headsign will fall back to trip_headsign

[2martens]

Summary

If a stop_headsign is not set, OTP will fall back to trip_headsign.

Issue

#5204

Closes #5204

Unit tests

Added test that covers all scenarios:

trip_headsign	stop_headsign	result
null	null	null
DIRECTION	null	DIRECTION
null	DIRECTION	DIRECTION
DIRECTION	DIRECTION	DIRECTION
DIRECTION	STOP	STOP

Additionally verified the solution manually with our data.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (b228933) 65.39% compared to head (f7d7918) 65.54%.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5205      +/-   ##
=============================================
+ Coverage      65.39%   65.54%   +0.15%     
- Complexity     14476    14614     +138     
=============================================
  Files           1755     1761       +6     
  Lines          68005    68343     +338     
  Branches        7230     7289      +59     
=============================================
+ Hits           44474    44798     +324     
+ Misses         21067    21055      -12     
- Partials        2464     2490      +26     

Impacted Files	Coverage Δ
...tripplanner/transit/model/timetable/TripTimes.java	81.88% <100.00%> (+0.13%)	⬆️

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[leonardehrenfried]

Can you autoformat your code?

[2martens]

I had already done it. But apparently there are still things missing.

[leonardehrenfried]

We already have a TripTimesTest but it's in the wrong package.

Can you move it here and rename it TripTimesUpdateTest?

[2martens]

With a bit of refactoring, it was actually quite easy to merge both test classes.

[leonardehrenfried]

Thanks for that.

Could I perhaps ask for one more round of refactoring?

• remove the @BeforeAll from createInitialTripTimes, simply call the method in those tests that actually need it and make originalTripTimes a local variable
• move your headsign tests into a nested class with the @nested annotation, like this

I know it's a bit nitpicky but I like well structured tests.

[2martens]

Will look into it.

[leonardehrenfried]

@hbtjma I'm assuming that you don't have the merge permission so I will take the liberty to do it for you.

[leonardehrenfried]

Related: #5290