Area vertex linking improvements#5209
Merged
vesameskanen merged 11 commits intoJun 22, 2023
Merged
Conversation
When vertex is linked to a private area, no thru restrictions must be considered properly. Otherwise walking cannot exit the private area.
Sometimes VertexLinker snaps to an existing vertex close to the point to be linked. In such a case, it is not necessary to generate new links with area visiblility points, because that has been already done by walkable area builder.
…ons in area linking
vesameskanen
added
!Bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5209 +/- ##
==========================================
Coverage 65.44% 65.44%
- Complexity 14494 14500 +6
==========================================
Files 1754 1754
Lines 68021 68057 +36
Branches 7238 7246 +8
==========================================
+ Hits 44515 44540 +25
- Misses 21041 21046 +5
- Partials 2465 2471 +6
☔ View full report in Codecov by Sentry. |
….java Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
vpaturet
requested changes
Jun 22, 2023
vpaturet
approved these changes
Jun 22, 2023
leonardehrenfried
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vertex linker now checks access restrictions (no thru traffic) when connecting new vertices with surrounding area edges. Previously there was a bug that walk routing could not exit areas tagged as access=private or access=destination.
Vertex linker no longer connects linked vertex inside an area with all visibility points, if the vertex was snapped to an existing visibility vertex due to small distance. Snapped visibility vertex already has the visibility connections, so there is no need to generate a new set of them. This fixes extremely slow linking near vertices which have many (sometimes over 100) existing connections.
Vertex linker now has upper limit for visibility point connections. It is currently defined as class constant just like other linking parameters. It now has the value 300, meaning that routing can exit a complex area via maximally that many exit points. The are notoriously complex areas in Lund, Sweden, consisting of thousands of vertices, so this may have a positive effect on routing performance.
Issue
Closes #5203
Unit tests