Flex build time and memory optimization for large zones - #5233
Merged
leonardehrenfried merged 15 commits intoJul 18, 2023
Merged
Conversation
leonardehrenfried
added
!Optimization
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5233 +/- ##
=============================================
+ Coverage 65.69% 65.71% +0.02%
- Complexity 14723 14732 +9
=============================================
Files 1770 1770
Lines 68556 68579 +23
Branches 7288 7283 -5
=============================================
+ Hits 45037 45069 +32
+ Misses 21025 21021 -4
+ Partials 2494 2489 -5
☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
flex-optimization
branch
from
July 12, 2023 12:50
e92b983 to
14e7188
Compare
leonardehrenfried
added
the
!Technical Debt
leonardehrenfried
force-pushed
the
flex-optimization
branch
from
July 12, 2023 14:52
14e7188 to
9f77317
Compare
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
Contributor
There was a problem hiding this comment.
See my comments so far.
binh-dam-ibigroup
previously approved these changes
Jul 17, 2023
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
Contributor
There was a problem hiding this comment.
I'm able to request flex trips with this PR , using Hopelink feeds, and the latest changes look good!
leonardehrenfried
force-pushed
the
flex-optimization
branch
from
July 18, 2023 12:41
5428a5f to
465aca1
Compare
vpaturet
previously approved these changes
Jul 18, 2023
binh-dam-ibigroup
approved these changes
Jul 18, 2023
vpaturet
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IBI has a few OTP installations which have very large flex zones (covering entire US counties and more) and
@miles-grant-ibigroup and @daniel-heppner-ibigroup have reported that in those cases build times are slow and memory consumption is very high.
This PR optimizes the build time by parallelizing it and uses an immutable
Setto conserve memory - beforehand each Vertex would keep an instance ofHashSetwhich uses potentially more space than necessary.Unit tests
Added.