Fix pathway traversal time calculation when none is supplied - #5242
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5242 +/- ##
=============================================
+ Coverage 65.59% 65.69% +0.10%
- Complexity 14654 14725 +71
=============================================
Files 1765 1769 +4
Lines 68455 68568 +113
Branches 7280 7288 +8
=============================================
+ Hits 44901 45044 +143
+ Misses 21067 21026 -41
- Partials 2487 2498 +11
☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Jul 17, 2023
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Oh god, how embarrassing!
leonardehrenfried
added
+Skip Changelog
leonardehrenfried
changed the title
t2gran
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
traversal_timewas not specified for a pathway, the distance-based traversal time was calculated usingtime = distance * speedinstead oftime = distance / speed.This updates the calculation.
Issue
❌
Unit tests
☑️ - existing tests are updated
Documentation
No changes.
Changelog
☑️
Bumping the serialization version id
❌