Validate missing intermediate location in via requests#5253
Merged
vpaturet merged 2 commits intoAug 16, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5253 +/- ##
=============================================
+ Coverage 65.69% 65.90% +0.20%
- Complexity 14723 14782 +59
=============================================
Files 1770 1770
Lines 68556 68685 +129
Branches 7288 7278 -10
=============================================
+ Hits 45037 45265 +228
+ Misses 21025 20934 -91
+ Partials 2494 2486 -8
☔ View full report in Codecov by Sentry. |
t2gran
added
!Improvement
t2gran
requested changes
Jul 24, 2023
| GEOCODE_FROM_NOT_FOUND(440), | ||
| GEOCODE_TO_NOT_FOUND(450), | ||
| GEOCODE_FROM_TO_NOT_FOUND(460), | ||
| GEOCODE_INTERMEDIATE_NOT_FOUND(465), |
Member
There was a problem hiding this comment.
I know that the rest of the errors also have the same name but this error has nothing to do with geocoding. Should we perhaps not make it worse by giving a better name?
Contributor
Author
There was a problem hiding this comment.
would it make sense to rename them all in another PR with a new prefix TRIP or TRIP_SEARCH?
leonardehrenfried
requested changes
Aug 10, 2023
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Not sure what is more important: constistency or not using confusing names.
leonardehrenfried
approved these changes
Aug 15, 2023
t2gran
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in #5252, missing validation for the intermediate locations in via requests causes NullPointerExceptions.
This PR adds a validation rule on the intermediate location and ensures that clients get a meaningful error message
Issue
Closes #5252
Unit tests
✅
Documentation
No