Improve walk step narrative for entering/exiting stations and signposted pathways#5285
Merged
leonardehrenfried merged 13 commits intoAug 17, 2023
Merged
Conversation
leonardehrenfried
added
!Improvement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5285 +/- ##
=============================================
+ Coverage 65.99% 66.07% +0.07%
- Complexity 14890 14943 +53
=============================================
Files 1778 1780 +2
Lines 68912 68969 +57
Branches 7286 7287 +1
=============================================
+ Hits 45481 45572 +91
+ Misses 20946 20914 -32
+ Partials 2485 2483 -2
☔ View full report in Codecov by Sentry. |
miles-grant-ibigroup
approved these changes
Aug 14, 2023
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
Contributor
There was a problem hiding this comment.
Results are as expected, code looks good at first glance too! If I have proper review access I can leave a more detailed review
optionsome
previously approved these changes
Aug 15, 2023
| public Edge backEdge; | ||
|
|
||
| // allow traverse result chaining (multiple results) | ||
| protected State next; |
Member
There was a problem hiding this comment.
We have had an unused field in the state?
Member
Author
There was a problem hiding this comment.
Yes, I removed the accessor methods in #4841 but never the actual field. 😱
vpaturet
previously approved these changes
Aug 16, 2023
leonardehrenfried
dismissed stale reviews from vpaturet and optionsome
via
August 16, 2023 14:27
1a8ad58
Member
Author
|
I had merge dev-2.x because of a conflict with #5267. |
leonardehrenfried
enabled auto-merge
August 16, 2023 14:30
optionsome
approved these changes
Aug 16, 2023
vpaturet
approved these changes
Aug 17, 2023
t2gran
pushed a commit
that referenced
this pull request
Aug 17, 2023
t2gran
pushed a commit
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 3 three new relative direction instructions: "enter station", "exit station" and "follow signs". The information for it is taken from the GTFS data.
Refactoring
The following refactorings are also in this PR:
Pathwaywas renamed tosignpostedAsto better reflect the difference between those two concepts.Unit tests
Added.
Documentation
Javadoc.