Add leg.headsign to GTFS GraphQL API - #5290
Merged
leonardehrenfried merged 1 commit intoAug 15, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5290 +/- ##
=============================================
- Coverage 65.92% 65.92% -0.01%
- Complexity 14802 14807 +5
=============================================
Files 1770 1770
Lines 68702 68704 +2
Branches 7283 7283
=============================================
+ Hits 45294 45295 +1
- Misses 20921 20925 +4
+ Partials 2487 2484 -3
☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
graphql-headsign
branch
from
August 15, 2023 07:52
809cdd1 to
71de501
Compare
leonardehrenfried
force-pushed
the
graphql-headsign
branch
from
August 15, 2023 08:03
71de501 to
6e30336
Compare
leonardehrenfried
requested review from
optionsome and
t2gran
and removed request for
t2gran
August 15, 2023 09:46
Member
Author
|
@t2gran has reviewed the non-sandbox code and is fine with it. @optionsome will be the only reviewer. |
optionsome
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@binh-dam-ibigroup has reported that in the GTFS GraphQL API a leg's headsign (as opposed the trip's) is not available, even though the internal model already contains the field and it was previously returned in the REST API.
This PR adds it.
Unit tests
Added.
Documentation
Added.