Remove Winkki street note updater - #5305
Merged
leonardehrenfried merged 3 commits intoAug 29, 2023
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5305 +/- ##
=============================================
+ Coverage 66.23% 66.33% +0.10%
- Complexity 15129 15155 +26
=============================================
Files 1787 1782 -5
Lines 69197 69128 -69
Branches 7348 7338 -10
=============================================
+ Hits 45832 45857 +25
+ Misses 20881 20784 -97
- Partials 2484 2487 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
added
the
!Technical Debt
leonardehrenfried
force-pushed
the
remove-winkki
branch
from
August 18, 2023 09:34
83481a5 to
460ad9b
Compare
optionsome
reviewed
Aug 18, 2023
|
|
||
| /** | ||
| * A source of notes for edges. | ||
| * A notes source of static notes, usually created at graph building stage and not modified |
optionsome
reviewed
Aug 21, 2023
optionsome
approved these changes
Aug 24, 2023
leonardehrenfried
enabled auto-merge
August 25, 2023 15:41
vpaturet
approved these changes
Aug 29, 2023
Member
Author
|
Not that it matters a lot but removing the Maven dependency has reduced the shaded jar size by 6.5MB!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in the dev meeting, this removes the Winkki street note updater since we cannot find anyone that is actually using it.
Closes #5301
cc @hannesj