Fix value mapping for bikesAllowed in GTFS GraphQL API - #5368
Merged
leonardehrenfried merged 3 commits intoSep 25, 2023
Conversation
leonardehrenfried
added
the
!Bug
leonardehrenfried
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5368 +/- ##
=============================================
+ Coverage 66.49% 66.51% +0.01%
- Complexity 15234 15236 +2
=============================================
Files 1785 1786 +1
Lines 69269 69266 -3
Branches 7291 7291
=============================================
+ Hits 46063 46069 +6
+ Misses 20737 20728 -9
Partials 2469 2469
☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
bikes-allowed
branch
from
September 21, 2023 15:06
4c74c67 to
0abf7f3
Compare
optionsome
approved these changes
Sep 22, 2023
leonardehrenfried
enabled auto-merge
September 22, 2023 12:15
jtorin
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If you request the
bikesAllowedresolver of the GTFS API it would incorrectly return the valueNOT_POSSIBLEwhen it should beNOT_ALLOWED, according to the schema. This would lead to an error for the resolver instead of the value.This PR fixes this problem.
Unit tests
Added.