Add validation for missing calls in SIRI update

[vpaturet]

Summary

When a SIRI update creates a new trip without estimated calls, the update fails with the following error message:

Adding EstimatedJourney EstimatedVehicleJourney{EstimatedVehicleJourneyCode: 'GOA:ServiceJourney:20231003-921967', Operator: GOA:Operator:GOA, VehicleModes: [BUS], Line: GOA:Line:50} failed. java.lang.NullPointerException: null
	at java.base/java.util.Objects.requireNonNull(Objects.java:209)
	at java.base/java.util.ImmutableCollections.listFromArray(ImmutableCollections.java:190)
	at java.base/java.util.List.of(List.java:1047)
	at org.opentripplanner.transit.model.network.StopPattern.getStops(StopPattern.java:174)
	at org.opentripplanner.transit.model.network.TripPattern.getStops(TripPattern.java:199)
	at org.opentripplanner.transit.model.network.RoutingTripPattern.<init>(RoutingTripPattern.java:32)
	at org.opentripplanner.transit.model.network.TripPattern.<init>(TripPattern.java:103)
	at org.opentripplanner.transit.model.network.TripPatternBuilder.buildFromValues(TripPatternBuilder.java:117)
	at org.opentripplanner.transit.model.network.TripPatternBuilder.buildFromValues(TripPatternBuilder.java:17)
	at org.opentripplanner.transit.model.framework.AbstractBuilder.build(AbstractBuilder.java:29)
	at org.opentripplanner.ext.siri.AddedTripBuilder.build(AddedTripBuilder.java:190)
	at org.opentripplanner.ext.siri.SiriTimetableSnapshotSource.apply(SiriTimetableSnapshotSource.java:211)
	at org.opentripplanner.ext.siri.SiriTimetableSnapshotSource.applyEstimatedTimetable(SiriTimetableSnapshotSource.java:169)
	at org.opentripplanner.ext.siri.updater.SiriETGooglePubsubUpdater.lambda$processSiriData$0(SiriETGooglePubsubUpdater.java:380)
	at org.opentripplanner.updater.GraphUpdaterManager.lambda$execute$1(GraphUpdaterManager.java:192)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)

This PR ensures that the SIRI updater checks earlier in the process if the added trip has no call and reports a validation error.

@lassetyr should the validation reject as well EstimatedVehicleJourneys with less than 2 calls?

Issue

No

Unit tests

Added unit test

Documentation

No

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b0d9a18) 66.60% compared to head (5b8fa6b) 66.60%.

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #5403   +/-   ##
==========================================
  Coverage      66.60%   66.60%           
- Complexity     15279    15284    +5     
==========================================
  Files           1790     1790           
  Lines          69364    69371    +7     
  Branches        7306     7309    +3     
==========================================
+ Hits           46197    46205    +8     
  Misses         20690    20690           
+ Partials        2477     2476    -1     

Files	Coverage Δ
...org/opentripplanner/ext/siri/AddedTripBuilder.java	73.58% <100.00%> (+1.21%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vpaturet]

@lassetyr I updated the validation to reject updates with less than 2 calls and those that refer to unknown stops.