Fix flexible quay querying in Transmodel API

[vpaturet]

Summary

When querying a flexible quay in the Transmodel API:

query {
  quay(
    id: "SOF:FlexibleStopPlace:ef157b1b-58d7-4431-942d-dc6042f4cae3"
  ) {
    name
    id
    estimatedCalls {
      expectedDepartureTime
      destinationDisplay {
        frontText
      }
      serviceJourney {
        line {
          publicCode
          transportMode
        }
      }
    }
  }
}

an exception is thrown:

Exception while fetching data (/quays[100689]/estimatedCalls) : class org.opentripplanner.transit.model.site.AreaStop cannot be cast to class org.opentripplanner.transit.model.site.RegularStop (org.opentripplanner.transit.model.site.AreaStop and org.opentripplanner.transit.model.site.RegularStop are in unnamed module of loader 'app')
java.lang.ClassCastException: class org.opentripplanner.transit.model.site.AreaStop cannot be cast to class org.opentripplanner.transit.model.site.RegularStop (org.opentripplanner.transit.model.site.AreaStop and org.opentripplanner.transit.model.site.RegularStop are in unnamed module of loader 'app')
	at org.opentripplanner.ext.transmodelapi.model.stop.QuayType.lambda$create$11(QuayType.java:320)
	at graphql.execution.ExecutionStrategy.invokeDataFetcher(ExecutionStrategy.java:311)
	at graphql.execution.ExecutionStrategy.fetchField(ExecutionStrategy.java:287)
	at graphql.execution.ExecutionStrategy.resolveFieldWithInfo(ExecutionStrategy.java:213)
	at graphql.execution.AsyncExecutionStrategy.execute(AsyncExecutionStrategy.java:55)
	at graphql.execution.ExecutionStrategy.completeValueForObject(ExecutionStrategy.java:702)
	at graphql.execution.ExecutionStrategy.completeValue(ExecutionStrategy.java:484)
	at graphql.execution.ExecutionStrategy.completeValueForList(ExecutionStrategy.java:586)
	at graphql.execution.ExecutionStrategy.completeValueForList(ExecutionStrategy.java:543)
	at graphql.execution.ExecutionStrategy.completeValue(ExecutionStrategy.java:469)
	at graphql.execution.ExecutionStrategy.completeField(ExecutionStrategy.java:435)
	at graphql.execution.ExecutionStrategy.lambda$resolveFieldWithInfo$1(ExecutionStrategy.java:215)
	at java.base/java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:684)
	at java.base/java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:662)
	at java.base/java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:2168)
	at graphql.execution.ExecutionStrategy.resolveFieldWithInfo(ExecutionStrategy.java:214)
	at graphql.execution.AsyncExecutionStrategy.execute(AsyncExecutionStrategy.java:55)
	at graphql.execution.Execution.executeOperation(Execution.java:161)
	at graphql.execution.Execution.execute(Execution.java:103)
	at graphql.GraphQL.execute(GraphQL.java:565)
	at graphql.GraphQL.lambda$parseValidateAndExecute$12(GraphQL.java:484)
	at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1187)
	at java.base/java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2309)
	at graphql.GraphQL.parseValidateAndExecute(GraphQL.java:479)
	at graphql.GraphQL.executeAsync(GraphQL.java:438)
	at graphql.GraphQL.execute(GraphQL.java:365)
	at org.opentripplanner.ext.transmodelapi.TransmodelGraph.executeGraphQL(TransmodelGraph.java:67)
	at org.opentripplanner.ext.transmodelapi.TransmodelAPI.getGraphQL(TransmodelAPI.java:122)

This PR makes it possible to query flexible quays.

Issue

No.

Unit tests

✅

Documentation

No.

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9695a96) 66.59% compared to head (75d5a8d) 66.59%.
Report is 3 commits behind head on dev-2.x.

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #5417   +/-   ##
==========================================
  Coverage      66.59%   66.59%           
  Complexity     15284    15284           
==========================================
  Files           1790     1790           
  Lines          69388    69386    -2     
  Branches        7308     7308           
==========================================
- Hits           46206    46205    -1     
+ Misses         20703    20702    -1     
  Partials        2479     2479           

Files	Coverage Δ
...planner/ext/transmodelapi/model/stop/QuayType.java	75.20% <27.27%> (+0.59%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.