Add stricter validation for flex areas - #5457
Merged
vpaturet merged 1 commit intoOct 27, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5457 +/- ##
==========================================
Coverage 66.87% 66.87%
Complexity 15495 15495
==========================================
Files 1800 1800
Lines 69801 69803 +2
Branches 7353 7354 +1
==========================================
+ Hits 46676 46678 +2
- Misses 20665 20666 +1
+ Partials 2460 2459 -1
☔ View full report in Codecov by Sentry. |
vpaturet
force-pushed
the
add_stricter_flex_area_validation
branch
from
October 27, 2023 09:28
acc6396 to
4d5fc5e
Compare
vpaturet
marked this pull request as ready for review
October 27, 2023 09:31
testower
approved these changes
Oct 27, 2023
leonardehrenfried
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the graph builder ignores some types of geometry errors when importing NeTEx flex data.

In particular self-intersecting polygons are imported without any validation error:
This PR applies a stricter validation when parsing polygons so that invalid areas are rejected (i.e. ignored) during graph building.
Issue
No
Unit tests
Added unit test
Documentation
No