Remove matchBusRoutesToStreets#5523
Merged
leonardehrenfried merged 2 commits intoNov 30, 2023
Merged
Conversation
leonardehrenfried
added
the
!Technical Debt
leonardehrenfried
changed the title
BusRouteStreetMatchermatchBusRoutesToStreets
leonardehrenfried
force-pushed
the
remove-bus-matcher
branch
from
7b317fe to
0edf21f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5523 +/- ##
=============================================
+ Coverage 67.14% 67.19% +0.05%
+ Complexity 16088 16042 -46
=============================================
Files 1856 1850 -6
Lines 71280 70919 -361
Branches 7465 7409 -56
=============================================
- Hits 47859 47653 -206
+ Misses 20925 20800 -125
+ Partials 2496 2466 -30 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
remove-bus-matcher
branch
from
0edf21f to
1e2e580
Compare
leonardehrenfried
force-pushed
the
remove-bus-matcher
branch
from
1e2e580 to
515bd95
Compare
jtorin
approved these changes
Nov 27, 2023
t2gran
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in a previous dev meeting, this PR removes the bus-to-street matching.
We cannot find anyone that is actually using this.
If you want this feature, I recommend that you use pfaedle.
Cleanup
This allows us to also reduce the mutability of
TripPatternwhich is my actual motivation for the change.