Create TripOnServiceDate for new siri realtime servicejourneys#5542
Merged
habrahamsson-skanetrafiken merged 3 commits intoDec 13, 2023
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5542 +/- ##
=============================================
+ Coverage 67.21% 67.23% +0.02%
+ Complexity 16087 16082 -5
=============================================
Files 1852 1852
Lines 71003 70970 -33
Branches 7409 7399 -10
=============================================
- Hits 47724 47720 -4
+ Misses 20812 20782 -30
- Partials 2467 2468 +1 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
force-pushed
the
fix-added-trip-on-service-date
branch
from
1f83b5b to
84b1774
Compare
habrahamsson-skanetrafiken
force-pushed
the
fix-added-trip-on-service-date
branch
from
84b1774 to
04e369a
Compare
Bartosz-Kruba
previously approved these changes
Dec 7, 2023
Member
|
Can you resolve the conflicts? |
vpaturet
approved these changes
Dec 12, 2023
Bartosz-Kruba
approved these changes
Dec 13, 2023
t2gran
pushed a commit
that referenced
this pull request
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When adding a replacement journey in SIRI updater, we currently don't add a TripOnServiceDate so querying for DatedServiceJourney in transmodel graphql api will give null.
It looks like this issue was caused by #5140.
Previously there was code to add the TripOnServiceDate in the TimetableSnapshot but this is unused since #5140 so I remove that code as well in order to not have a lot of dead code lying around.
Issue
Closes #5540
Unit tests
I added the exected behaviour in a unit test.