Add same submode in alternative legs filter#5548
Merged
t2gran merged 5 commits intoDec 12, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5548 +/- ##
=============================================
+ Coverage 67.19% 67.20% +0.01%
- Complexity 16040 16085 +45
=============================================
Files 1850 1852 +2
Lines 70921 71002 +81
Branches 7410 7410
=============================================
+ Hits 47653 47720 +67
- Misses 20802 20813 +11
- Partials 2466 2469 +3 ☔ View full report in Codecov by Sentry. |
t2gran
requested changes
Dec 4, 2023
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
Looks good, except for the missing doc.
…EnumTypes.java Co-authored-by: Thomas Gran <t2gran@gmail.com>
Member
|
Please run |
leonardehrenfried
approved these changes
Dec 12, 2023
t2gran
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to filter for same submode in the alternative legs filter.
Issue
Closes #5300
Unit tests
All existing unit tests pass. Additionally tested manually by running locally.
Documentation
This is a trivial addition to existing functionality.