Fix preference cost comparisons - #5586
Merged
Merged
Conversation
optionsome
added
the
!Bug
optionsome
marked this pull request as ready for review
December 19, 2023 11:43
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5586 +/- ##
==========================================
Coverage 67.36% 67.36%
+ Complexity 16167 16164 -3
==========================================
Files 1858 1858
Lines 71093 71097 +4
Branches 7403 7406 +3
==========================================
+ Hits 47892 47896 +4
+ Misses 20745 20743 -2
- Partials 2456 2458 +2 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Dec 19, 2023
t2gran
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on some related things, I noticed some wrong equal checks on Costs. This fixes those and adds one missing field from a toString.
Issue
No issue as these are minor fixes but this can solve issues with transfer cache but most of these fixed fields are not exposed through any API.
Unit tests
Not updated, we might want to refactor tests related to these comparisons more in the future.
Documentation
Not updated
Changelog
From title