Use NeTEx authority short name if name is not present

[cambio-deca]

Summary

Add short name in Agency. Italian Netex file use ShortName tag instead Name in Authority.
If tag name is not filled and short name is filled, last one will be used as an agency name.

Unit tests

Test new field shortName.

[leonardehrenfried]

Hi there - welcome to OTP!

It looks like you are adding support for Italian Netex files.

Since this will require some attention from the maintainers of the the Netex code, I believe you will save time by showing up the developer meetings: https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/CONTRIBUTING.md#developer-meetings

There we talk about pull requests and assign reviews. It's also a good place to ask questions.

Lastly, all developers are in the Gitter chat room.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.71%. Comparing base (5da2268) to head (caf12a8).
Report is 13 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5698      +/-   ##
=============================================
+ Coverage      67.69%   67.71%   +0.01%     
- Complexity     16369    16377       +8     
=============================================
  Files           1890     1891       +1     
  Lines          71812    71881      +69     
  Branches        7407     7411       +4     
=============================================
+ Hits           48611    48672      +61     
- Misses         20693    20702       +9     
+ Partials        2508     2507       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonardehrenfried]

We spoke about this in the developer meeting today and we don't believe that the short name should end up in the internal data model. Using it as a fallback should simply be handled in the mapper code and you wouldn't even need to change the builder for this.

[leonardehrenfried]

Please move the mapping code to the mapper.