Repository navigation
Fix issue with cancellations on trip patterns that run after midnight - #5719
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5719 +/- ##
=============================================
+ Coverage 67.71% 67.80% +0.08%
- Complexity 16390 16524 +134
=============================================
Files 1895 1904 +9
Lines 71937 72265 +328
Branches 7415 7438 +23
=============================================
+ Hits 48711 48996 +285
- Misses 20717 20752 +35
- Partials 2509 2517 +8 ☔ View full report in Codecov by Sentry. |
|
HSL and Entur will test this in their production systems. |
|
I've deployed the change in Entur staging environment and could not see any regression. I did not test specifically the cancellation scenario the change aims to fix. |
|
If you write some documentation and tests, I'm happy to approve as well. |
|
I have now added tests, renamed some things and added javadoc. |
|
I'm happy to approve if @t2gran says that the rename to "serviceDate" is ok. |
|
The date in |
Summary
This fixes an issue that trips that belong to a trip pattern that has only trips which run after midnight on a specific date are used in routing despite being cancelled.
Issue
Closes #5718
Unit tests
Added
Documentation
Added javadoc.
Changelog
From title