Repository navigation
Fix world envelope builder when crossing Greenwich meridian - #5731
Conversation
1fbcc03 to
505661c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5731 +/- ##
==========================================
Coverage 67.77% 67.78%
- Complexity 16474 16482 +8
==========================================
Files 1901 1901
Lines 72121 72135 +14
Branches 7430 7434 +4
==========================================
+ Hits 48881 48894 +13
Misses 20727 20727
- Partials 2513 2514 +1 ☔ View full report in Codecov by Sentry. |
|
Not sure if I was asleep or not when writing the test for this. I have clearly created a few test-cases, but not written test for them. There are not one bug here, but two - I fixed both in the following commit: I think you can apply this commit 81d7466. About the unit-test:
|
|
Note! When writing module and integration tests we do use samples - because we are not covering ereything (imposible) and we want to be close the the use-cases. |
505661c to
20ebfd4
Compare
- The envelope calculation was wrong when envelope included0º (Greenwich) - The medianCenter was wrong when the envelope included 180º
20ebfd4 to
747246e
Compare
|
Thanks for this, @t2gran . I've applied your commit and removed mine. |
|
I have reviewed and tested it. It works. |
t2gran
left a comment
There was a problem hiding this comment.
Approving this on behalf of @leonardehrenfried and myself.
Summary
I was working with a UK data set today and noticed that half of the debug tiles were not displayed correctly.
The cut off went right through the middle of London near the Greenwich meridian.
It turns out that the lower left tile boundaries in the debug client, which are derived from the world envelope builder, are too far east.
The fix was a tiny change to the
WorldEnvelopeBuilder: the problem was that when we have a data set crossing the meridian, we need to go as far west as possible but using the smallest (most negative) number, not the largest one, which would be around Greenwich.Unit tests
Added.
Documentation
Added.