Skip to content

Expose route sort order in GTFS API#5764

Merged
leonardehrenfried merged 5 commits into
opentripplanner:dev-2.xfrom
ibi-group:route-sort-order
Mar 28, 2024
Merged

Expose route sort order in GTFS API#5764
leonardehrenfried merged 5 commits into
opentripplanner:dev-2.xfrom
ibi-group:route-sort-order

Conversation

@leonardehrenfried

Copy link
Copy Markdown
Member

Summary

@fpurcell has requested that we parse the GTFS field route_sort_order and expose it in the API. It turns out that we already have it in the internal model and I only needed to implement the second part.

While I was there I did bit of validation and clean up.

Issue

Closes #5763

Unit tests

Added.

Documentation

Javadoc

@leonardehrenfried leonardehrenfried added !Improvement A functional improvement or micro feature +GTFS Related to import of GTFS data labels Mar 22, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner March 22, 2024 09:46
@codecov

codecov Bot commented Mar 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.81%. Comparing base (92c1264) to head (1d330b0).
Report is 39 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5764      +/-   ##
=============================================
+ Coverage      67.78%   67.81%   +0.02%     
- Complexity     16521    16531      +10     
=============================================
  Files           1904     1906       +2     
  Lines          72269    72275       +6     
  Branches        7438     7443       +5     
=============================================
+ Hits           48990    49013      +23     
+ Misses         20761    20742      -19     
- Partials        2518     2520       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binh-dam-ibigroup

Copy link
Copy Markdown
Contributor

@fpurcell has requested that we parse the GTFS field route_sort_order and expose it in the API. It turns out that we already have it in the internal model and I only needed to implement the second part.

@leonardehrenfried Cool, it will be useful for folks working on the mobile app too.

@leonardehrenfried

Copy link
Copy Markdown
Member Author

@binh-dam-ibigroup Would you be available to review this?

@binh-dam-ibigroup

Copy link
Copy Markdown
Contributor

@binh-dam-ibigroup Would you be available to review this?

Sure!

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and works as indicated. Just two minor non-code tweaks.

Comment thread src/main/resources/org/opentripplanner/apis/gtfs/schema.graphqls
Comment thread src/test/java/org/opentripplanner/apis/gtfs/GraphQLIntegrationTest.java Outdated
Comment thread src/main/java/org/opentripplanner/transit/model/network/Route.java
@leonardehrenfried leonardehrenfried merged commit fb52054 into opentripplanner:dev-2.x Mar 28, 2024
t2gran pushed a commit that referenced this pull request Mar 28, 2024
@leonardehrenfried leonardehrenfried deleted the route-sort-order branch March 28, 2024 15:15
@t2gran t2gran added this to the 2.6 (next release) milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+GTFS Related to import of GTFS data !Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

route_sort_order: pass values through graphql

5 participants