Expose route sort order in GTFS API#5764
Conversation
ad5a1e9 to
d2a0126
Compare
cb1687c to
4f73e2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5764 +/- ##
=============================================
+ Coverage 67.78% 67.81% +0.02%
- Complexity 16521 16531 +10
=============================================
Files 1904 1906 +2
Lines 72269 72275 +6
Branches 7438 7443 +5
=============================================
+ Hits 48990 49013 +23
+ Misses 20761 20742 -19
- Partials 2518 2520 +2 ☔ View full report in Codecov by Sentry. |
@leonardehrenfried Cool, it will be useful for folks working on the mobile app too. |
|
@binh-dam-ibigroup Would you be available to review this? |
Sure! |
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Clean and works as indicated. Just two minor non-code tweaks.
4547306 to
1d330b0
Compare
Summary
@fpurcell has requested that we parse the GTFS field
route_sort_orderand expose it in the API. It turns out that we already have it in the internal model and I only needed to implement the second part.While I was there I did bit of validation and clean up.
Issue
Closes #5763
Unit tests
Added.
Documentation
Javadoc