Overwrite default WALK directMode when it is not set in the request, but modes is set#5779
Merged
Merged
Conversation
Defaulting it to walk when it was not set caused issues when the user expected no results because transportModes are defined.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5779 +/- ##
==========================================
Coverage 67.81% 67.81%
Complexity 16531 16531
==========================================
Files 1906 1906
Lines 72275 72274 -1
Branches 7443 7442 -1
==========================================
+ Hits 49012 49014 +2
+ Misses 20742 20740 -2
+ Partials 2521 2520 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
see #5675 for the original PR that sets the defaults on access/egress/direct mode |
leonardehrenfried
approved these changes
Apr 9, 2024
vpaturet
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overwrite default WALK directMode when it is not set in the request, but modes is set. Defaulting it to walk when it was not set caused issues when the user expected no results because transportModes are defined.
Unit tests
Updated existing unit test to pass. Also verified that the results are as expected with the related Entur Shamash Query
Documentation
Updated JavaDoc.