Discourage instead of ban cycling on use_sidepath ways and do the same for walking on foot=use_sidepath - #5790
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5790 +/- ##
=============================================
+ Coverage 67.81% 67.85% +0.03%
- Complexity 16534 16539 +5
=============================================
Files 1906 1906
Lines 72277 72285 +8
Branches 7443 7439 -4
=============================================
+ Hits 49017 49048 +31
+ Misses 20740 20716 -24
- Partials 2520 2521 +1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
previously approved these changes
Apr 5, 2024
vesameskanen
previously approved these changes
Apr 8, 2024
optionsome
dismissed stale reviews from vesameskanen and leonardehrenfried
via
April 9, 2024 14:06
bf11e9f
leonardehrenfried
approved these changes
Apr 10, 2024
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Thanks for generalizing your solution.
vesameskanen
approved these changes
Apr 10, 2024
Member
Author
|
Entur also gave approval so I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cycling on bicycle=use_sidepath is no longer banned but discouraged with safety values. foot=use_sidepath has no same effect for walking. For Finland mapper, also walking is discouraged when bicycle=use_sidepath is used.
This fixes some occurances where we get a route through a road with cars with walking even though there is a walking path close to the road that is tagged to the car road in OSM with either foot=use_sidepath or bicycle=use_sidepath.
For example https://www.openstreetmap.org/way/574874058
Issue
No issue as minor OSM mapper change.
Unit tests
Updated tests
Documentation
No need to update
Changelog
From title