Skip to content

Discourage instead of ban cycling on use_sidepath ways and do the same for walking on foot=use_sidepath - #5790

Merged
optionsome merged 2 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:use-sidepath
Apr 11, 2024
Merged

Discourage instead of ban cycling on use_sidepath ways and do the same for walking on foot=use_sidepath#5790
optionsome merged 2 commits into
opentripplanner:dev-2.xfrom
HSLdevcom:use-sidepath

Conversation

@optionsome

@optionsome optionsome commented Apr 5, 2024

Copy link
Copy Markdown
Member

Summary

Cycling on bicycle=use_sidepath is no longer banned but discouraged with safety values. foot=use_sidepath has no same effect for walking. For Finland mapper, also walking is discouraged when bicycle=use_sidepath is used.

This fixes some occurances where we get a route through a road with cars with walking even though there is a walking path close to the road that is tagged to the car road in OSM with either foot=use_sidepath or bicycle=use_sidepath.

For example https://www.openstreetmap.org/way/574874058

before
after

Issue

No issue as minor OSM mapper change.

Unit tests

Updated tests

Documentation

No need to update

Changelog

From title

@optionsome optionsome added !Improvement A functional improvement or micro feature +Skip Changelog This is not a relevant change for a product owner since last release. labels Apr 5, 2024
@optionsome optionsome added this to the 2.6 (next release) milestone Apr 5, 2024
@optionsome
optionsome requested a review from a team as a code owner April 5, 2024 16:20
@codecov

codecov Bot commented Apr 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (30dee5f) to head (bf11e9f).
Report is 11 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5790      +/-   ##
=============================================
+ Coverage      67.81%   67.85%   +0.03%     
- Complexity     16534    16539       +5     
=============================================
  Files           1906     1906              
  Lines          72277    72285       +8     
  Branches        7443     7439       -4     
=============================================
+ Hits           49017    49048      +31     
+ Misses         20740    20716      -24     
- Partials        2520     2521       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vesameskanen
vesameskanen previously approved these changes Apr 8, 2024
@optionsome optionsome changed the title Discourage walking when sidepaths are available with Finland OSM mapper Discourage instead of ban cycling on use_sidepath ways and do the same for walking on foot=use_sidepath Apr 9, 2024
@optionsome optionsome removed the +Skip Changelog This is not a relevant change for a product owner since last release. label Apr 9, 2024
@optionsome optionsome changed the title Discourage instead of ban cycling on use_sidepath ways and do the same for walking on foot=use_sidepath Discourage instead of banning cycling on use_sidepath ways and do the same for walking on foot=use_sidepath Apr 9, 2024

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for generalizing your solution.

@leonardehrenfried leonardehrenfried changed the title Discourage instead of banning cycling on use_sidepath ways and do the same for walking on foot=use_sidepath Discourage instead of ban cycling on use_sidepath ways and do the same for walking on foot=use_sidepath Apr 11, 2024
@optionsome

Copy link
Copy Markdown
Member Author

Entur also gave approval so I'll merge this.

@optionsome
optionsome merged commit ad49e64 into opentripplanner:dev-2.x Apr 11, 2024
@optionsome
optionsome deleted the use-sidepath branch April 11, 2024 12:43
t2gran pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants