Add feed publisher name and url to GTFS GraphQL API

[vesameskanen]

Summary

Add fetchers for FeedInfo publisherName and publisherUrl information.

Unit tests

Feedinfo test query added.

Documentation

In gtfs graphql schema.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (203fcdd) to head (a181803).
Report is 194 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5835      +/-   ##
=============================================
+ Coverage      67.91%   68.40%   +0.49%     
- Complexity     16559    16698     +139     
=============================================
  Files           1910     1915       +5     
  Lines          72438    72679     +241     
  Branches        7447     7453       +6     
=============================================
+ Hits           49194    49718     +524     
+ Misses         20724    20404     -320     
- Partials        2520     2557      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonardehrenfried]

Can you add a test like this: https://github.com/opentripplanner/OpenTripPlanner/blob/621b802d93a2eb595b645b77be21a36da7314842/src/test/resources/org/opentripplanner/apis/gtfs/queries/alerts.graphql#L1-L0

You have to set up some mock data like this:

OpenTripPlanner/src/test/java/org/opentripplanner/apis/gtfs/GraphQLIntegrationTest.java

Line 152 in 39fe08e

transitModel.addTripPattern(id("pattern-1"), pattern);

[vesameskanen]

OK I will add the test, thanks for instructions!

[vesameskanen]

Data is now structured.

[leonardehrenfried]

If you have anyone at hsl that can be second reviewer in Joel's absence, you can assign them.

[optionsome]

With GTFS these are required but how about NETEX?

[leonardehrenfried]

I believe that in Netex you don't have a feed publisher at all and you're right: the publisher should be optional. If these two fields should be optional, I'm not sure about.

[leonardehrenfried]

Actually, I realised something: you need to also map the FeedPublisher type in graphql-codegen.yml:

OpenTripPlanner/src/main/java/org/opentripplanner/apis/gtfs/generated/graphql-codegen.yml

Line 115 in 6cb475c

StopPosition: org.opentripplanner.apis.gtfs.model.StopPosition#StopPosition

[leonardehrenfried]

Just a small doc change.

[vesameskanen]

Out of curiosity, what is this convention of double-double-quotes around comments while single double quotes seem to work as well?

[leonardehrenfried]

Out of curiosity, what is this convention of double-double-quotes around comments while single double quotes seem to work as well?

This allows you to write multi-line doc strings. Regular single-quoted strings have to stay on one line.