Skip to content

Remove TravelTime API - #5890

Merged
t2gran merged 2 commits into
opentripplanner:dev-2.xfrom
entur:remove_traveltime
Jun 12, 2024
Merged

Remove TravelTime API#5890
t2gran merged 2 commits into
opentripplanner:dev-2.xfrom
entur:remove_traveltime

Conversation

@t2gran

@t2gran t2gran commented Jun 4, 2024

Copy link
Copy Markdown
Member

Summary

The Travel Time (Sandbox) feature is removed. There are no resources to maintain this and the current/first implementation of this has its limitations.

Issue

Close #4880

Unit tests

The feature is removed, there was not tests.

Documentation

Doc is updated.

Changelog

Bumping the serialization version id

🟥 No changes

@t2gran t2gran added +Sandbox This will be implemented as a Sandbox feature !Technical Debt Improve code quality, no functional changes. +Config Change This PR might require the configuration to be updated. labels Jun 4, 2024
@t2gran t2gran added this to the 2.6 (next release) milestone Jun 4, 2024
@t2gran
t2gran requested a review from a team as a code owner June 4, 2024 13:41
@codecov

codecov Bot commented Jun 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.31%. Comparing base (d6d5534) to head (40af8ab).

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5890      +/-   ##
=============================================
+ Coverage      68.62%   69.31%   +0.69%     
+ Complexity     16825    16819       -6     
=============================================
  Files           1927     1910      -17     
  Lines          72930    72181     -749     
  Branches        7475     7338     -137     
=============================================
- Hits           50045    50035      -10     
+ Misses         20312    19573     -739     
  Partials        2573     2573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vpaturet

vpaturet commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

@t2gran could you fix the conflict?

@t2gran
t2gran merged commit 831ff13 into opentripplanner:dev-2.x Jun 12, 2024
@t2gran
t2gran deleted the remove_traveltime branch June 12, 2024 07:36
t2gran pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Config Change This PR might require the configuration to be updated. +Sandbox This will be implemented as a Sandbox feature !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travel time (isochrone) improvements (by arrival, time window if feasible)

3 participants