Fix parsing of GBFS feeds - #5891
Merged
leonardehrenfried merged 2 commits intoJun 7, 2024
Merged
Conversation
leonardehrenfried
added
the
!Bug
leonardehrenfried
approved these changes
Jun 5, 2024
leonardehrenfried
enabled auto-merge
June 5, 2024 04:18
vpaturet
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the GBFS model moved to MobilityData an inadvertent change was made to the implementing class mapper, so gbfs.json pointed to the generated class for v2.3, which does not work. The upgrade includes MobilityData/gbfs-json-schema#129 which reverts to the original behavior of mapping to the hand-written class.
Issue
Closes #5889
Unit tests
Test case courtesy of @leonardehrenfried (ibi-group@ff938e3)