Skip to content

Don't use elevation data directly for ways with cutting=*, location=underground or indoor=yes tags in the default mapper#6093

Merged
optionsome merged 1 commit into
opentripplanner:dev-2.xfrom
HSLdevcom:slope-overrides
Oct 3, 2024
Merged

Don't use elevation data directly for ways with cutting=*, location=underground or indoor=yes tags in the default mapper#6093
optionsome merged 1 commit into
opentripplanner:dev-2.xfrom
HSLdevcom:slope-overrides

Conversation

@optionsome

Copy link
Copy Markdown
Member

Summary

Copies over the rules from Norway mapper for disabling the elevation usage for the for the following tag value combinations to the default mapper as well:

cutting=*
location=underground
indoor=yes

Issue

Related to #6092

Unit tests

Added some

Documentation

Not needed

Changelog

From title

@optionsome optionsome added the !Improvement A functional improvement or micro feature label Sep 26, 2024
@optionsome
optionsome requested a review from a team as a code owner September 26, 2024 16:09
@leonardehrenfried

Copy link
Copy Markdown
Member

Does this solve your specific indoor mall problem?

@optionsome

Copy link
Copy Markdown
Member Author

Does this solve your specific indoor mall problem?

I think it fixes the original problem but not all problems.

This is before:
image (3)

This is after:
soukka

@optionsome
optionsome merged commit 02f6535 into opentripplanner:dev-2.x Oct 3, 2024
@optionsome
optionsome deleted the slope-overrides branch October 3, 2024 13:32
t2gran pushed a commit that referenced this pull request Oct 3, 2024
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Improvement A functional improvement or micro feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants