Un-deprecate GTFS API's planConnection, deprecate plan - #6110
Conversation
leonardehrenfried
changed the title
planConnection, deprecate plan
leonardehrenfried
added
the
!Improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6110 +/- ##
=============================================
- Coverage 69.85% 69.84% -0.02%
+ Complexity 17468 17457 -11
=============================================
Files 1975 1973 -2
Lines 74614 74566 -48
Branches 7640 7637 -3
=============================================
- Hits 52118 52077 -41
+ Misses 19848 19841 -7
Partials 2648 2648 ☔ View full report in Codecov by Sentry. |
|
We agreed that this can happen now. |
optionsome
left a comment
optionsome
left a comment
There was a problem hiding this comment.
walk-steps integration test still uses the old plan query
| /* | ||
| * Hide the deprecated queries from the left hand navigation panel. | ||
| */ | ||
| nav ul li .deprecated { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
How are they displayed without this? I'm just wondering since sometimes we use the deprecated on experimental queries (like we did for planConnection in the past), and I'm not sure if we want to hide their existence completely.
There was a problem hiding this comment.
It removes them from the left hand navigation but you can still access them from the search and if you type in the URL.
5bb6f83 to
550e8ba
Compare
4 participants
Summary
Deprecates the
planquery and un-deprecatesplanConnectionwhich has been used by HSL in production for several month.Issue
#4803
Unit tests
I moved most of the integration tests from
plantoplanConnection. A single test forplanremains.Documentation
The tutorial was updated with the new query.
Also, I added a CSS override so that the deprecated queries no longer show up in our HTML documentation of the schema.