Make indoor=area and indoor=corridor routable for UK OSM tag mapper

[miklcct]

PR Instructions

Summary

This makes indoor=area and indoor=corridor routable with pedestrian permission.

It consists of 3 parts.

1. Refactor existing area handling.
2. Make indoor=area, indoor=corridor areas.
3. Assign pedestrian permissions to indoor=area and indoor=corridor.

Issue

Fixes #6118

Unit tests

Added to test areas and permissions

Documentation

Generated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.91%. Comparing base (e58513f) to head (5cc750a).
Report is 16 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6119      +/-   ##
=============================================
- Coverage      69.91%   69.91%   -0.01%     
- Complexity     17701    17715      +14     
=============================================
  Files           1996     1996              
  Lines          75305    75338      +33     
  Branches        7705     7719      +14     
=============================================
+ Hits           52646    52669      +23     
- Misses         19989    19992       +3     
- Partials        2670     2677       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miklcct]

Sorry for the delays and problems. Java is not my best thing for me to work at, our current production is at 2.6 and the module refactor in 2.7 has made massive headache for me in setting up my IDE.

[vesameskanen]

Code is OK but this change is not totally problem free. I checked ten cities around the world to understand where and how indoor=area is used. It is quite rare in data. In half of the cases I found, indoor=area is applied to restaurants and shops in shopping center or market hall. Routing should not use those kind of areas. Anyway, in some cities, especially in Paris, there are significant structures where indoor area routing would be useful. For example: https://www.openstreetmap.org/way/558799205 .

It is also necessary to test how well OTP can handle overlapping indoor areas on different levels.

[miklcct]

Code is OK but this change is not totally problem free. I checked ten cities around the world to understand where and how indoor=area is used. It is quite rare in data. In half of the cases I found, indoor=area is applied to restaurants and shops in shopping center or market hall. Routing should not use those kind of areas. Anyway, in some cities, especially in Paris, there are significant structures where indoor area routing would be useful. For example: https://www.openstreetmap.org/way/558799205 .

It is also necessary to test how well OTP can handle overlapping indoor areas on different levels.

That may be a problem as it seems that, from the wiki, that indoor=area and indoor=room are distinguished by if they are enclosed by walls, rather than the usage of the place. (indoor=area is not walled, while indoor=room is by default, walled). In this case possibly if these places are not intended for through traffic, some access= tags are needed.

I have just sent an email to the tagging mailing list for discussion.

[vesameskanen]

Getting the OSM data obey some new guidelines will take time. Meanwhile, we might consider configuring suitable permissions in OTP tag mapping.

I guess indoor=corridor sounds like always routable. We might require some additional tags from indoor areas to make them routable. Also, it is possible to add routing permissions to certain countries only using application/src/test/java/org/opentripplanner/osm/tagmapping/ mapper classes. I noticed that indoor tag conventions seem to vary heavily on each country.

Currently there is a bug which by default grants pedestrian and bicycle access to areas, and ignores country specific tag mapping. I have already fixed this and will open a PR soon.