Fix GTFS-Flex duration offset and factor parsing when only one of them is set - #6138
Merged
vpaturet merged 1 commit intoOct 11, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6138 +/- ##
==========================================
Coverage 69.85% 69.86%
- Complexity 17491 17497 +6
==========================================
Files 1976 1976
Lines 74712 74717 +5
Branches 7645 7647 +2
==========================================
+ Hits 52192 52200 +8
Misses 19868 19868
+ Partials 2652 2649 -3 ☔ View full report in Codecov by Sentry. |
vpaturet
added
!Bug
LeoFrachet
marked this pull request as ready for review
October 10, 2024 13:28
vpaturet
self-requested a review
October 10, 2024 13:28
leonardehrenfried
approved these changes
Oct 10, 2024
vpaturet
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Instructions
Summary
Currently, if only one of the
safe_duration_offsetorsafe_duration_factoris set, OTP crashes.This PR fixes that by providing default for the other one if only of them is set.
Issue
No.
Unit tests
Unit tests added.
Documentation
No