Interpret GTFS extended route types 801-899 also as trolleybus service#6170
Merged
Merged
Conversation
optionsome
reviewed
Oct 21, 2024
optionsome
left a comment
optionsome
left a comment
Member
There was a problem hiding this comment.
If someone is using extended types between 800-899, this will change the output mode but I think they are quite rare. I would be ok with merging these changes.
Member
|
@flaktack does this affect your deployments? |
Contributor
|
No, merging is fine with us. |
flaktack
approved these changes
Oct 22, 2024
optionsome
approved these changes
Oct 28, 2024
optionsome
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6170 +/- ##
=============================================
+ Coverage 69.93% 69.96% +0.03%
- Complexity 17730 17749 +19
=============================================
Files 1996 1996
Lines 75402 75416 +14
Branches 7717 7717
=============================================
+ Hits 52731 52767 +36
+ Misses 19995 19979 -16
+ Partials 2676 2670 -6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix GTFS extended route types for trolleybus (8xx).
This replaces #6086 for trolleybuses only, and add tests for existing modes (except 200-299).
Issue
None yet
Unit tests
added for more existing modes
Documentation
None