update the description of "CABLE_CAR" mode to cable tram.#6173
Merged
t2gran merged 2 commits intoOct 24, 2024
Conversation
This was referenced Oct 17, 2024
Member
|
These changes are good, but we do not want the changes in The other changes are good! |
it is no longer maintained
optionsome
approved these changes
Oct 24, 2024
t2gran
approved these changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6173 +/- ##
=============================================
- Coverage 69.93% 69.93% -0.01%
+ Complexity 17730 17726 -4
=============================================
Files 1996 1996
Lines 75402 75402
Branches 7717 7717
=============================================
- Hits 52731 52729 -2
- Misses 19995 19996 +1
- Partials 2676 2677 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cable car, in GTFS terminology which uses American English, is a rail vehicle running on street propelled by a cable.
However, in British English, the term "cable car" has a completely separate meaning which has caused confusion,
and the official specification has been updated to use the term "cable tram" as a result.
This changes all references to "cable car" to "cable tram" in the UI code and documentations.
However, it isn't possible to change the name of the enum item without breaking backward compatibility.
Issue
google/transit#186
Unit tests
None, as this is a pure documentation change.
Documentation
Updated