Remove reading agency and route brandingUrl from GTFS data

[tkalvas]

Summary

Remove the property brandingUrl from the internal data model for agency and route.

Do not read, but still accept, the nonstandard extension brandingUrl for those GTFS files.

Unit tests

Updated the tests to no longer check for brandingUrl.

Documentation

No change.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.94%. Comparing base (30216e9) to head (785ac67).
Report is 108 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6183      +/-   ##
=============================================
+ Coverage      69.92%   69.94%   +0.02%     
- Complexity     17730    17741      +11     
=============================================
  Files           1996     1997       +1     
  Lines          75416    75435      +19     
  Branches        7717     7722       +5     
=============================================
+ Hits           52734    52763      +29     
- Misses         20000    20004       +4     
+ Partials        2682     2668      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[optionsome]

We seem to also include brandingUrl from GTFS routes.txt which is also some non-standard field. Should we consider removing that support as well? Seems like at least that's reusing same branding type as netex data.

[tkalvas]

We seem to also include brandingUrl from GTFS routes.txt which is also some non-standard field. Should we consider removing that support as well? Seems like at least that's reusing same branding type as netex data.

I think yes. I didn't notice that, but now that I look at it, it would make sense to remove that at the same time.

[optionsome]

I think you can remove the initialization of BRANDING_URL for route in this class so we don't have to update this test class if the brandingUrl gets removed from the OBA library at some point.