Skip to content

Fix max search-window when paging#6189

Merged
t2gran merged 3 commits into
opentripplanner:dev-2.xfrom
entur:doc-sw
Oct 29, 2024
Merged

Fix max search-window when paging#6189
t2gran merged 3 commits into
opentripplanner:dev-2.xfrom
entur:doc-sw

Conversation

@t2gran

@t2gran t2gran commented Oct 23, 2024

Copy link
Copy Markdown
Member

Summary

The PagingService was initialized with the dynamic max-search-window value, and not the request max search-window. This commit also updates the Transmodel API doc.

Issue

This was reported at Entur yesterday. It is a minor fix, so I have not created an issue for it.

Unit tests

This was an error in the wiring of the application - creating a good test for this is expensive and give little value.

Documentation

✅ The Transmodel API doc is updated.
✅ JavaDoc and code comments is updated/added
🟥 The GTFS API is not updated - someone who knows the API should do this

Changelog

Bumping the serialization version id

Not needed.

@t2gran t2gran added !Bug Apply to issues describing a bug and PRs witch fixes it. !Documentation Improve documentation targeting users and/or developers. Entur Test This is currently being tested at Entur labels Oct 23, 2024
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 23, 2024
@t2gran t2gran requested a review from a team as a code owner October 23, 2024 11:59
@t2gran t2gran requested a review from eibakke October 23, 2024 11:59
@codecov

codecov Bot commented Oct 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (cee960f) to head (4d3fff1).
Report is 32 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...opentripplanner/apis/transmodel/TransmodelAPI.java 0.00% 3 Missing ⚠️
...ner/standalone/configure/ConstructApplication.java 0.00% 2 Missing ⚠️
...standalone/server/DefaultServerRequestContext.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6189   +/-   ##
==========================================
  Coverage      69.90%   69.90%           
+ Complexity     17723    17722    -1     
==========================================
  Files           1998     1998           
  Lines          75443    75453   +10     
  Branches        7718     7718           
==========================================
+ Hits           52740    52748    +8     
- Misses         20025    20026    +1     
- Partials        2678     2679    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The PagingService was initialized with the dynamic max-search-window value, and not the request max search-window.
This commit also updates the Transmodel API doc.
@optionsome optionsome requested a review from jtorin October 24, 2024 14:37
@t2gran t2gran merged commit e4d92eb into opentripplanner:dev-2.x Oct 29, 2024
@t2gran t2gran deleted the doc-sw branch October 29, 2024 19:49
t2gran pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. !Documentation Improve documentation targeting users and/or developers. Entur Test This is currently being tested at Entur

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants