Skip to content

Deprecate old alert translations in the GTFS API and add language param to a few alert fields - #6216

Merged
optionsome merged 1 commit into
opentripplanner:dev-2.xfrom
HSLdevcom:deprecate-alert-translations
Nov 12, 2024
Merged

Deprecate old alert translations in the GTFS API and add language param to a few alert fields#6216
optionsome merged 1 commit into
opentripplanner:dev-2.xfrom
HSLdevcom:deprecate-alert-translations

Conversation

@optionsome

Copy link
Copy Markdown
Member

Summary

This deprecates old alert translations fields from GTFS API and add language param to normal fields.

Issue

Minor GraphQL API update, no issue

Unit tests

Updated tests

Documentation

Not needed

Changelog

From title

@optionsome
optionsome requested a review from a team as a code owner November 2, 2024 22:44
@codecov

codecov Bot commented Nov 2, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69.92%. Comparing base (c15ee47) to head (36381e8).
Report is 189 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ntripplanner/apis/gtfs/generated/GraphQLTypes.java 0.00% 21 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6216      +/-   ##
=============================================
- Coverage      69.95%   69.92%   -0.04%     
+ Complexity     17757    17748       -9     
=============================================
  Files           1999     1999              
  Lines          75500    75517      +17     
  Branches        7728     7733       +5     
=============================================
- Hits           52813    52802      -11     
- Misses         20012    20040      +28     
  Partials        2675     2675              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optionsome
optionsome merged commit 115b4d4 into opentripplanner:dev-2.x Nov 12, 2024
@optionsome
optionsome deleted the deprecate-alert-translations branch November 12, 2024 09:31
t2gran pushed a commit that referenced this pull request Nov 12, 2024
@t2gran t2gran added this to the 2.7 (next release) milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants