Implement alert node query in GTFS GraphQL API - #6225
Merged
leonardehrenfried merged 5 commits intoNov 6, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6225 +/- ##
=============================================
+ Coverage 69.91% 69.94% +0.03%
- Complexity 17736 17741 +5
=============================================
Files 2006 2006
Lines 75526 75526
Branches 7730 7730
=============================================
+ Hits 52804 52827 +23
+ Misses 20036 20008 -28
- Partials 2686 2691 +5 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
requested review from
leonardehrenfried and
vesameskanen
November 5, 2024 11:04
Member
|
Please add a test. |
leonardehrenfried
changed the title
vesameskanen
previously approved these changes
Nov 6, 2024
| assertEquals(STOP_ID, filteredAlerts.get(0).getId()); | ||
| } | ||
|
|
||
| @Test |
Member
There was a problem hiding this comment.
You can do it much simpler: just drop a file like node-alert.graphql here: https://github.com/opentripplanner/OpenTripPlanner/tree/dev-2.x/application/src/test/resources/org/opentripplanner/apis/gtfs/queries
Then run GraphQLIntegrationTest.
These tests also double up as API examples for newcomers.
This reverts commit 48c2bf9.
leonardehrenfried
approved these changes
Nov 6, 2024
vesameskanen
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement refetching of alerts by ID.
Issue
Fixes #6224
Unit tests
Added with stub services
Documentation
None needed
Changelog
N/A
Bumping the serialization version id
N/A