Relax rejection of GTFS flex trips that also contain continuous stopping#6231
Conversation
leonardehrenfried
added
!Bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6231 +/- ##
=============================================
- Coverage 69.75% 69.71% -0.05%
- Complexity 17652 17695 +43
=============================================
Files 2007 2008 +1
Lines 75563 75834 +271
Branches 7731 7765 +34
=============================================
+ Hits 52711 52865 +154
- Misses 20141 20256 +115
- Partials 2711 2713 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@m-mcqueen @fpurcell If you want to you can try out this version and deploy it to your servers before review has concluded. |
leonardehrenfried
added
the
+Bump Serialization Id
leonardehrenfried
force-pushed
the
flex-continuous
branch
from
c3370c1 to
ac64f85
Compare
leonardehrenfried
force-pushed
the
flex-continuous
branch
from
ac64f85 to
8f6ba7b
Compare
| public static StopTime areaWithContinuousStopping(String time) { | ||
| var st = area(time, time); | ||
| st.setFlexContinuousPickup(PickDrop.COORDINATE_WITH_DRIVER); | ||
| st.setFlexContinuousDropOff(PickDrop.COORDINATE_WITH_DRIVER); |
There was a problem hiding this comment.
Does continuous drop-off imply continuous pick-up? (That also makes this test case overlap with the next one.)
There was a problem hiding this comment.
In the spec these are completely different things but of course you would be hard pressed to find an example in the real world where you can only be dropped off continuously but not picked up.
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
CobbLinc flex service, used in the tests, has been discontinued. I don't mind continue using the feed for the former service as long as we say in the code that the service no longer exists. Or, we can use a current feed of another agency.
| * contains both flex zones but also scheduled stops. Inside the zone, passengers can get on or off | ||
| * anywhere, so there it works more like a taxi. | ||
| * <p> | ||
| * Read about the details at: https://www.cobbcounty.org/transportation/cobblinc/routes-and-schedules/flex |
There was a problem hiding this comment.
Cobb County no longer offers the transit flex service described and switched it to an on-demand micromobility service which is no-longer fare-integrated with the rest of CobbLinc. (And the link is broken as a result.) Should we use a different feed that contains a service to the former flex service?
There was a problem hiding this comment.
I think we want to have fewer integration tests and more unit tests, so I would just update the Javadoc.
leonardehrenfried
requested review from
binh-dam-ibigroup and
habrahamsson-skanetrafiken
4 participants
Summary
This brings OTP in line with the GTFS spec by allowing flex and continuous stopping in the same trip as long as it's not mixed in the very same stop time.
There is also a small improvement to the debug UI where routes without a publicCode/shortName use the long name as the fallback.
Issue
Closes #6230
Unit tests
The majority of the code is test refactoring. Lots of tests for this behavior added.
Documentation
n/a
Bumping the serialization version id
I'm changing static method on a file that is being serialised so I'm bumping just in case.