Skip to content

Make motorroad=yes car-only#6288

Merged
leonardehrenfried merged 4 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:motorroad
Dec 3, 2024
Merged

Make motorroad=yes car-only#6288
leonardehrenfried merged 4 commits into
opentripplanner:dev-2.xfrom
leonardehrenfried:motorroad

Conversation

@leonardehrenfried
Copy link
Copy Markdown
Member

Summary

Make OSM ways tagged with motorroad=yes car-only.

Before

Screenshot From 2024-11-28 11-12-43

After

Screenshot From 2024-11-28 11-07-44

Issue

Closes #6287

Unit tests

Added.

Documentation

Autogenerated.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner November 28, 2024 10:18
@leonardehrenfried leonardehrenfried added the !Bug Apply to issues describing a bug and PRs witch fixes it. label Nov 28, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.79%. Comparing base (2cc3ce4) to head (2aefc16).
Report is 45 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6288      +/-   ##
=============================================
+ Coverage      69.76%   69.79%   +0.02%     
- Complexity     17750    17785      +35     
=============================================
  Files           2010     2017       +7     
  Lines          75948    76042      +94     
  Branches        7784     7781       -3     
=============================================
+ Hits           52983    53071      +88     
- Misses         20257    20266       +9     
+ Partials        2708     2705       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried
Copy link
Copy Markdown
Member Author

@vesameskanen Can you review this?

@leonardehrenfried
Copy link
Copy Markdown
Member Author

cc @stadtnavimanager

@vesameskanen vesameskanen self-requested a review November 28, 2024 11:07
vesameskanen
vesameskanen previously approved these changes Nov 28, 2024
@leonardehrenfried
Copy link
Copy Markdown
Member Author

@eibakke Can I ask you to review this one? If not let me know and I will reassign.

Comment thread application/src/main/java/org/opentripplanner/osm/tagmapping/OsmTagMapper.java Outdated
@leonardehrenfried leonardehrenfried merged commit 54f69b0 into opentripplanner:dev-2.x Dec 3, 2024
t2gran pushed a commit that referenced this pull request Dec 3, 2024
@leonardehrenfried leonardehrenfried deleted the motorroad branch December 3, 2024 14:00
@tkalvas tkalvas requested review from tkalvas and removed request for tkalvas December 3, 2024 16:41
@t2gran t2gran added this to the 2.7 (next release) milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

motorroad=yes used for pedestrians

4 participants