Make flex linking work together with boarding locations#6311
Merged
leonardehrenfried merged 5 commits intoDec 19, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6311 +/- ##
===========================================
Coverage 69.79% 69.79%
- Complexity 17798 17821 +23
===========================================
Files 2019 2020 +1
Lines 76126 76234 +108
Branches 7786 7800 +14
===========================================
+ Hits 53132 53210 +78
- Misses 20288 20309 +21
- Partials 2706 2715 +9 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
added
the
!Bug
Contributor
|
Will it cause #5498 to appear again? If not, what's the difference? |
Member
Author
|
No, it will not reappear. The difference is that linking to both walk and drive edges is ensured in all cases, even the stop has previously been linked to a boarding location. This is ensured by unit tests. |
Member
Author
|
@vesameskanen Can I ask you to review this? |
binh-dam-ibigroup
requested changes
Dec 9, 2024
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
Contributor
There was a problem hiding this comment.
Logic seems fine, but could you clarify the link order and fix a typo please?
binh-dam-ibigroup
approved these changes
Dec 10, 2024
vesameskanen
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It links flex stops also to the drivable street network even when they are already linked to an OSM boarding location.
Issue
Closes #6299
Unit tests
Added.
Documentation
Javadoc.