Release script for downstream OTP forks - #6345
Conversation
83f13fb to
0e4a19f
Compare
|
|
|
There are formatting issues. |
b58fcc8 to
77a9ed5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6345 +/- ##
=============================================
+ Coverage 70.31% 70.35% +0.03%
- Complexity 18158 18170 +12
=============================================
Files 2058 2062 +4
Lines 76942 76931 -11
Branches 7773 7763 -10
=============================================
+ Hits 54101 54123 +22
+ Misses 20086 20051 -35
- Partials 2755 2757 +2 ☔ View full report in Codecov by Sentry. |
|
I have improved the error handling in the scripts and simplified a bit. Ready for review. |
optionsome
left a comment
There was a problem hiding this comment.
I would prefer if there was a directory under the script directory for these files so you can have just a regular README for it.
e65c45e to
010f2ce
Compare
e6b6b10 to
5dcecf9
Compare
5dcecf9 to
d622a1c
Compare
|
At Entur we use this this in the GitHub workflow. You may copy the workflow scripts if you want. Here is how we want to set up our pipeline - we have a data pipeline as well, but that is not shown. |
| print(f'DEBUG {msg}', flush=True) | ||
|
|
||
|
|
||
| def crop(text): |
There was a problem hiding this comment.
Someone will come up with an error situation where they want the entire output.
There was a problem hiding this comment.
Improvements are always welcome. For example dumping everything to a custom-release.log file and crop terminal output is fine with me. The script potentially print the 20 versions of the root pom.xml in addition to running Maven, so the log can be long - I prefer cropping some of it, so it is easier to find the important stuff. I have also modified the script to print everything a couple of times to debug.
There was a problem hiding this comment.
Yes, I guess it's best to crop the log which is going to stdout, and write the full log to a file in /tmp
|
Thank you for a good review @tkalvas, I renamed and rewrote a lot to make it generic (not Entur specific) - sorry for all the misstakes. I have tested the script after my changes - it still works. |
Summary
This PR contain two scripts
custom-release.pyandchangelog-diff.pyto make a release in a DOWNSTREAM fork of OTP. These scripts are not intended for releasing the main OTP repository.See the (CUSTOM_RELEASE_README)[script/CUSTOM_RELEASE_README.md] for documentation of
custom-release.py.The
changelog-diff.pycan be used to diff the changelog.md file for any two versions of OTP.Issue
🟥 There is not issue for this. But, these scripts is requested from time to time. This PR provides a common place to maintain them. At Entur we now run the
custom-release.pyas the first step in our OTP CI/CD Pipeline.Unit tests
🟥 No tests provided.
Documentation
✅ The scripts are documented in the readme, se above.
Changelog
✅ This is relevant for advanced deplyments.
Bumping the serialization version id
🟥 Not relevant.