Repository navigation
Make it possible to add custom API documentation based on the deployment location - #6355
Merged
tkalvas merged 10 commits intoJan 16, 2025
Merged
Conversation
…eplacer. This enable us to use this in places where we do not want to inject environment variables.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6355 +/- ##
=============================================
- Coverage 69.85% 69.82% -0.03%
- Complexity 17926 17993 +67
=============================================
Files 2035 2050 +15
Lines 76508 76792 +284
Branches 7825 7840 +15
=============================================
+ Hits 53442 53619 +177
- Misses 20325 20424 +99
- Partials 2741 2749 +8 ☔ View full report in Codecov by Sentry. |
In the case used, we compare to GraphQL schemas.
t2gran
force-pushed
the
custom-doc-transmodel-api
branch
from
January 2, 2025 14:10
4de6666 to
0bf3c72
Compare
t2gran
force-pushed
the
custom-doc-transmodel-api
branch
from
January 2, 2025 18:54
1f4cae2 to
f2406e7
Compare
habrahamsson-skanetrafiken
requested review from
leonardehrenfried and
tkalvas
January 7, 2025 10:33
leonardehrenfried
requested changes
Jan 7, 2025
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
There are a few things that I picked up on, mainly that properties files in Java are assumed to be ISO-8869-1.
tkalvas
previously approved these changes
Jan 8, 2025
Co-authored-by: Leonard Ehrenfried <mail@leonard.io>
t2gran
force-pushed
the
custom-doc-transmodel-api
branch
from
January 13, 2025 22:24
06b76b4 to
106ab13
Compare
leonardehrenfried
approved these changes
Jan 14, 2025
tkalvas
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduce a new configuration parameter to load a deployment specific properies file.
router-config.json
custom-documentation-entur.properties
Syntax properties file
Use:
<TypeName>[.<FieldName>].(description|deprecated)[.append]Examples
Replace the existing type description
Quay.description=The place for boarding/alighting a vehicleAppend to the existing type description
Quay.description.append=This is appendedReplace the existing field description
Quay.name.description=The name of a Quay is ...Append to the existing field description
Quay.name.description.append=(Source NSR)Insert deprecated reason. Due to a bug in the Java GraphQL lib, an existing deprecated reason cannot be updated, but it can be deprecated if not already marked. Deleting the reason from the schema, and adding it back using
the "default" TransmodelApiDocumentationProfile can be used as a workaround. The problem is reported to the Java GraphQL Prodject here: graphql-java/graphql-java#3786.
Quay.name.deprecated=This field is deprecated ...Issue
🟥 No isse exist for this.
Unit tests
✅ All new code have unit-tests
Documentation
✅ JavaDoc and user doc is added/updated.
Changelog
✅ This is a new feature
Bumping the serialization version id
🟥 Not needed