When using ScheduledTransitLeg's copy builder, also copy alerts - #6368
Merged
leonardehrenfried merged 2 commits intoJan 13, 2025
Merged
Conversation
leonardehrenfried
added
the
!Bug
leonardehrenfried
force-pushed
the
fix-alerts
branch
from
January 9, 2025 08:49
1cf4506 to
75f712a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6368 +/- ##
=============================================
- Coverage 69.79% 69.78% -0.01%
+ Complexity 17943 17941 -2
=============================================
Files 2046 2046
Lines 76685 76689 +4
Branches 7829 7829
=============================================
+ Hits 53520 53521 +1
- Misses 20423 20425 +2
- Partials 2742 2743 +1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
fix-alerts
branch
from
January 9, 2025 11:33
75f712a to
1bfc833
Compare
optionsome
reviewed
Jan 9, 2025
optionsome
approved these changes
Jan 9, 2025
leonardehrenfried
enabled auto-merge
January 9, 2025 15:38
binh-dam-ibigroup
approved these changes
Jan 13, 2025
t2gran
pushed a commit
that referenced
this pull request
Jan 13, 2025
This was referenced Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug where transit alerts where not copied when using the leg to get a new builder.
This PR only fixes the bug but I will work on making the
ScheduledTransitLegcompletely immutable so this doesn't happen again (we have the same problem with the fares).Unit tests
Added.